mark dataset test static for test index#164
Merged
Merged
Conversation
LHT129
commented
Nov 27, 2024
LHT129
commented
Collaborator
- fix some typo error
- clean code
- mark dataset static for test index to speed up functest
LHT129
added
the
kind/improvement
- fix some typo error - clean code - mark dataset static for test index to speed up functest Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
reviewed
Nov 27, 2024
|
|
||
| private: | ||
| mutable std::unordered_map<std::string, std::shared_ptr<TestDataset>> datasets; | ||
| static std::unordered_map<std::string, TestDatasetPtr> datasets; |
Collaborator
There was a problem hiding this comment.
will there be concurrency issues here?
Collaborator
Author
There was a problem hiding this comment.
no concurrent test for this now
inabao
reviewed
Nov 27, 2024
| return result; | ||
| } | ||
|
|
||
| std::unordered_map<std::string, TestDatasetPtr> TestIndex::datasets = {}; |
Collaborator
There was a problem hiding this comment.
why do we need to make it static?
Collaborator
Author
There was a problem hiding this comment.
dataset may be same for all test
jiaweizone
reviewed
Nov 28, 2024
| auto querys = dataset->query_; | ||
| auto query_count = querys->GetNumElements(); | ||
| auto dim = querys->GetDim(); | ||
| auto queries = dataset->query_; |
Collaborator
There was a problem hiding this comment.
we need rename dataset query_ to query ?
Roxanne0321
pushed a commit
to Roxanne0321/vsag
that referenced
this pull request
Mar 3, 2025
- fix some typo error - clean code - mark dataset static for test index to speed up functest Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
jiacai2050
pushed a commit
to jiacai2050/vsag
that referenced
this pull request
Mar 6, 2025
- fix some typo error - clean code - mark dataset static for test index to speed up functest Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
that referenced
this pull request
May 11, 2026
- fix some typo error - clean code - mark dataset static for test index to speed up functest Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
- fix some typo error - clean code - mark dataset static for test index to speed up functest Signed-off-by: LHT129 <tianlan.lht@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.