Skip to content

handle the bad alloc exception in vector search#21

Merged
wxyucs merged 1 commit into
mainfrom
handlering_bad_alloc_exception
Sep 6, 2024
Merged

handle the bad alloc exception in vector search#21
wxyucs merged 1 commit into
mainfrom
handlering_bad_alloc_exception

Conversation

@wxyucs

@wxyucs wxyucs commented Sep 6, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@wxyucs
wxyucs force-pushed the handlering_bad_alloc_exception branch from 82be33e to 84987d6 Compare September 6, 2024 06:18
@LHT129
LHT129 self-requested a review September 6, 2024 06:24

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/index/hnsw.cpp
allocator = DefaultAllocator::Instance();
}
allocator_ = allocator;
allocator_ = new SafeAllocator(allocator);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SafeAllocator need free ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, release at deconstruct function

Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
@wxyucs
wxyucs force-pushed the handlering_bad_alloc_exception branch from 84987d6 to 598dd60 Compare September 6, 2024 06:54

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs
wxyucs merged commit 689fd51 into main Sep 6, 2024
@wxyucs
wxyucs deleted the handlering_bad_alloc_exception branch September 6, 2024 07:21
@wxyucs wxyucs changed the title handler the bad alloc exception in vector search handle the bad alloc exception in vector search Sep 6, 2024
wxyucs added a commit that referenced this pull request Sep 11, 2024
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Roxanne0321 pushed a commit to Roxanne0321/vsag that referenced this pull request Mar 3, 2025
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants