fix: IVF nearest-partition basic test returns an unexpected class ID - #2595
Merged
Conversation
Signed-off-by: vsag-bot <276218163+vsag-bot@users.noreply.github.com> Assisted-by: Codex:gpt-5.6-sol
vsag-bot
requested review from
LHT129,
inabao,
jiaweizone and
wxyucs
as code owners
July 31, 2026 22:28
Collaborator
Author
|
/label status/waiting-for-review |
Collaborator
Author
|
AI PR state: Automatic merging is disabled. A maintainer performs the final merge. |
Contributor
Merge Protections🟢 All 3 merge protections satisfied — ready to merge. Show 3 satisfied protections🟢 Require kind label
🟢 Require version label
🟢 Require linked issue for feature/bug PRs
|
LHT129
reviewed
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrected the flaky IVF basic test by comparing routing results produced with identical HGraph search breadth.
Root Cause
ClassifyDatas used ef_search=10 while the test's direct approximate HGraph search used ef_search=20. Different search breadths can legitimately select different partition IDs, making the assertion intermittent.
Changes
Validation
cmake --build build --parallel 4: passed - Generic-SIMD build completed with DISABLE_SSE_FORCE=1../build/tests/unittests 'IVF Nearest Partition Basic Test' --reporter compact (50 repetitions): passed - All repetitions passed, exercising threaded and serial paths../build/tests/unittests '[IVFNearestPartition]' --reporter compact: passed - 3003 assertions passed across both IVF nearest-partition tests.clang-format-15 --dry-run --Werror src/algorithm/ivf/ivf_nearest_partition_test.cpp: passed - Validated with clang-format 15.0.7.git diff --check: passed - No whitespace errors.Residual Risks
Base branch:
mainFixes #2594
Prepared by
vsag-botafter automatic effort ordering and AI repairability preflight.