fix: Add missing <functional> header for readerset.h#398
Merged
Conversation
Signed-off-by: Coien-rr <972054003@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 91.24% 91.25% +0.01%
==========================================
Files 140 140
Lines 8980 8980
==========================================
+ Hits 8194 8195 +1
+ Misses 786 785 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
wxyucs
added
the
kind/bug
jiacai2050
pushed a commit
to jiacai2050/vsag
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Coien-rr <972054003@qq.com>
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: Coien-rr <972054003@qq.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: Coien-rr <972054003@qq.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Coien-rr <972054003@qq.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue of missing
<functional>header, which is required for usingstd::functionin the definition of the
CallBacktype alias.Although
<functional>is included in all scenarios whereCallBackis currently referenced, so it doesn't lead to compilation errors. However, for the sake of code robustness and portability, I think that the<functional>header file should be added to the definition header file itself ofreaderset.h.