support build graph from existing graph storage in ODescent#406
Merged
Conversation
inabao
commented
Feb 17, 2025
| ODescent::Build(const uint32_t* valid_ids, | ||
| int64_t data_num, | ||
| const GraphInterfacePtr graph_storage) { | ||
| graph_.clear(); |
Collaborator
Author
There was a problem hiding this comment.
support build multi-graph with one graph builder
inabao
commented
Feb 17, 2025
| new_neighbors[i].reserve(max_degree_); | ||
| } | ||
| init_graph(); | ||
| init_graph(graph_storage); |
Collaborator
Author
There was a problem hiding this comment.
init from existing graph_storage
inabao
added
the
kind/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 91.34% 91.31% -0.03%
==========================================
Files 144 144
Lines 9290 9317 +27
==========================================
+ Hits 8486 8508 +22
- Misses 804 809 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jiaweizone
reviewed
Feb 17, 2025
| ODescent::init_graph(const GraphInterfacePtr graph_storage) { | ||
| graph_.resize(data_num_, Linklist(allocator_)); | ||
| UnorderedMap<uint32_t, uint32_t> inner_ids_to_locs(allocator_); | ||
| std::function<uint32_t(uint32_t)> id_map = nullptr; |
| uint32_t id = i; | ||
| if (data_num_ - 1 < max_degree_) { | ||
| id = (i + j + 1) % data_num_; | ||
| while (ids_set.find(id) != ids_set.end() && ids_set.size() <= max_neighbors) { |
Collaborator
There was a problem hiding this comment.
Here can optimize to:
if (ids_set.size() <= max_neighbors) {
while (ids_set.find(id) != ids_set.end()) {
// ....
}
}
Collaborator
Author
There was a problem hiding this comment.
I found that the check ids_set.size() <= max_neighbors is redundant, because valid_id_count < max_neighbors can actually guarantee that ids_set.size() <= max_neighbors. Therefore, I have removed the corresponding logic.
inabao
force-pushed
the
support-build-graph-from-exist-graph-storage
branch
from
February 18, 2025 06:16
65f6ff6 to
ef0d883
Compare
ShawnShawnYou
approved these changes
Feb 18, 2025
inabao
force-pushed
the
support-build-graph-from-exist-graph-storage
branch
from
February 19, 2025 02:34
0e358a3 to
04cada7
Compare
jiacai2050
pushed a commit
to jiacai2050/vsag
that referenced
this pull request
Mar 6, 2025
…#406) Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
…#406) Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
…#406) Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.