Skip to content

add performance pipeline in GitHub CI#421

Merged
wxyucs merged 1 commit into
mainfrom
update-tool-eval
Feb 27, 2025
Merged

add performance pipeline in GitHub CI#421
wxyucs merged 1 commit into
mainfrom
update-tool-eval

Conversation

@wxyucs

@wxyucs wxyucs commented Feb 19, 2025

Copy link
Copy Markdown
Collaborator

solve: #384

@codecov

codecov Bot commented Feb 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   92.07%   92.03%   -0.04%     
==========================================
  Files         164      164              
  Lines       10204    10206       +2     
==========================================
- Hits         9395     9393       -2     
- Misses        809      813       +4     
Flag Coverage Δ
cpp 92.03% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.94% <ø> (ø)
datacell 93.04% <ø> (-0.21%) ⬇️
index 91.57% <100.00%> (+<0.01%) ⬆️
simd 87.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77714f3...1e6685d. Read the comment docs.

@wxyucs
wxyucs force-pushed the update-tool-eval branch 3 times, most recently from 638166f to 1fc8758 Compare February 20, 2025 03:13
@wxyucs
wxyucs requested a review from LHT129 as a code owner February 20, 2025 03:13
@wxyucs
wxyucs force-pushed the update-tool-eval branch 11 times, most recently from d811046 to 51f6b1d Compare February 24, 2025 12:32
@wxyucs
wxyucs force-pushed the update-tool-eval branch 6 times, most recently from 19e1ba4 to 8eba844 Compare February 25, 2025 05:06
@wxyucs
wxyucs force-pushed the update-tool-eval branch 2 times, most recently from d04f5d6 to 6fb2db1 Compare February 25, 2025 06:55
@wxyucs wxyucs changed the title add performance regression pipeline in GitHub CI add performance pipeline in GitHub CI Feb 25, 2025
@wxyucs wxyucs added the kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 label Feb 25, 2025
@wxyucs
wxyucs force-pushed the update-tool-eval branch 4 times, most recently from 5844cef to d63e2f0 Compare February 26, 2025 07:25

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/perf-95.yml
Comment thread extern/tabulate/tabulate.cmake Outdated
tabulate
URL https://github.com/p-ranav/tabulate/archive/3a58301067bbc03da89ae5a51b3e05b7da719d38.tar.gz
# this url is maintained by the vsag project, if it's broken, please try
# the latest commit or contact the vsag project

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: indent

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


EvalCasePtr
EvalCase::MakeInstance(const EvalConfig& config) {
EvalCase::MakeInstance(const EvalConfig& config, std::string type) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const std::string& type

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type update in L46, cannot be const

Comment thread tools/eval/eval_config.cpp Outdated
void
EvalConfig::CheckKeyAndType(YAML::Node& yaml_node) {
check_exist_and_get_value<>(yaml_node, "datapath");
auto action = check_exist_and_get_value<>(yaml_node, "type");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: move to L139 ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wxyucs
wxyucs force-pushed the update-tool-eval branch 5 times, most recently from 67fc16b to 4bf134e Compare February 27, 2025 07:15
Signed-off-by: wxy407827 <wxy407827@antgroup.com>

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs
wxyucs merged commit 61cf67f into main Feb 27, 2025
@wxyucs
wxyucs deleted the update-tool-eval branch February 27, 2025 14:12
jiacai2050 pushed a commit to jiacai2050/vsag that referenced this pull request Mar 6, 2025
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: wxy407827 <wxy407827@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 module/tools size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants