Skip to content

refactor utils#433

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:cmake
Feb 25, 2025
Merged

refactor utils#433
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:cmake

Conversation

@LHT129

@LHT129 LHT129 commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator
  • move utils to utils/ directory
  • clean code on CMakeLists

@LHT129 LHT129 added kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO labels Feb 24, 2025
@LHT129 LHT129 self-assigned this Feb 24, 2025
@LHT129
LHT129 force-pushed the cmake branch 3 times, most recently from 5d5b27e to 84fe8cb Compare February 24, 2025 07:38

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         151      156    +5     
  Lines        9859     9859           
=======================================
  Hits         9032     9032           
  Misses        827      827           
Flag Coverage Δ
cpp 91.61% <98.18%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.19% <ø> (-0.89%) ⬇️
datacell 92.36% <ø> (+0.52%) ⬆️
index 90.76% <ø> (-0.17%) ⬇️
simd 87.71% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8097d3c...05f3425. Read the comment docs.

- move utils to utils/ directory
- clean code on CMakeLists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129
LHT129 merged commit 9429c5d into antgroup:main Feb 25, 2025
@LHT129
LHT129 deleted the cmake branch February 25, 2025 04:02
jiacai2050 pushed a commit to jiacai2050/vsag that referenced this pull request Mar 6, 2025
- move utils to utils/ directory
- clean code on CMakeLists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
- move utils to utils/ directory
- clean code on CMakeLists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
- move utils to utils/ directory
- clean code on CMakeLists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
- move utils to utils/ directory
- clean code on CMakeLists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 size/XL version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants