Introduce fp16 simd operators#436
Merged
Merged
Conversation
LHT129
added
kind/feature
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 92.07% 92.09% +0.02%
==========================================
Files 164 164
Lines 10204 10299 +95
==========================================
+ Hits 9395 9485 +90
- Misses 809 814 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
LHT129
marked this pull request as ready for review
February 24, 2025 12:11
LHT129
changed the title
LHT129
force-pushed
the
fp16
branch
3 times, most recently
from
February 27, 2025 06:19
fe8d57b to
493cdf5
Compare
| } | ||
|
|
||
| TEST_CASE("Encode & Decode FP16", "[ut][simd]") { | ||
| auto vec_fp32 = fixtures::generate_vectors(10, 100); |
Collaborator
There was a problem hiding this comment.
use more test cases, since fixtures::generate_vectors only generate small range or float
Collaborator
Author
There was a problem hiding this comment.
it's not a good idea to touch the limit of the fp16, because we will never guarantee the precise of the special number
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
ShawnShawnYou
approved these changes
Feb 27, 2025
jiacai2050
pushed a commit
to jiacai2050/vsag
that referenced
this pull request
Mar 6, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #437