introduce IVF index implement#456
Merged
Merged
Conversation
LHT129
added
kind/feature
LHT129
requested review from
ShawnShawnYou,
inabao,
jiaweizone and
wxyucs
as code owners
February 28, 2025 06:33
LHT129
force-pushed
the
ivf_impl
branch
2 times, most recently
from
March 1, 2025 03:58
2016613 to
0362266
Compare
jiaweizone
reviewed
Mar 2, 2025
| })"; | ||
|
|
||
| ParamPtr | ||
| IVF::MappingExternalParamAndCheck(const JsonType& external_param, |
Collaborator
There was a problem hiding this comment.
MappingExternalParamAndCheck -> CheckAndMappingExternalParam ？
Collaborator
Author
There was a problem hiding this comment.
Sometimes, we need check param valid after mapping
|
|
||
| IVFSearchParameters obj; | ||
|
|
||
| // set obj.ef_search |
Collaborator
There was a problem hiding this comment.
Q: ef_search for IVF is scan buckets count?
Collaborator
Author
There was a problem hiding this comment.
another param，not ef_search
LHT129
force-pushed
the
ivf_impl
branch
3 times, most recently
from
March 3, 2025 12:57
913700f to
39dc759
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 91.79% 91.97% +0.18%
==========================================
Files 168 172 +4
Lines 10431 10495 +64
==========================================
+ Hits 9575 9653 +78
+ Misses 856 842 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LHT129
force-pushed
the
ivf_impl
branch
2 times, most recently
from
March 4, 2025 02:45
e4a7d1a to
c36296b
Compare
LHT129
force-pushed
the
ivf_impl
branch
7 times, most recently
from
March 5, 2025 07:38
f4a5a3e to
a7fe5ba
Compare
wxyucs
reviewed
Mar 5, 2025
LHT129
force-pushed
the
ivf_impl
branch
2 times, most recently
from
March 6, 2025 03:12
70c3f70 to
7af865c
Compare
LHT129
force-pushed
the
ivf_impl
branch
2 times, most recently
from
March 6, 2025 06:37
0a2e331 to
743f069
Compare
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
inabao
reviewed
Mar 10, 2025
| bucket_->ScanBucketById(dist.data(), computer, bucket_id); | ||
| for (int j = 0; j < bucket_size; ++j) { | ||
| if (filter == nullptr or filter->CheckValid(labels[j])) { | ||
| if (dist[j] <= radius + 2e-6 and dist[j] < cur_heap_top) { |
Collaborator
Author
There was a problem hiding this comment.
I think all index need this constant, refactor in another PR
ShawnShawnYou
approved these changes
Mar 10, 2025
LHT129
added a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #276