Skip to content

fix ef search bug on hgraph#478

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:hgraph_ef
Mar 5, 2025
Merged

fix ef search bug on hgraph#478
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:hgraph_ef

Conversation

@LHT129

@LHT129 LHT129 commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

fix: #475

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 added the kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 label Mar 5, 2025
@LHT129 LHT129 self-assigned this Mar 5, 2025
@LHT129
LHT129 requested review from inabao and wxyucs as code owners March 5, 2025 07:10

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wxyucs wxyucs added needs-cherry-pick-release-0.13 version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO labels Mar 5, 2025
@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   91.83%   91.90%   +0.07%     
==========================================
  Files         168      168              
  Lines       10444    10431      -13     
==========================================
- Hits         9591     9587       -4     
+ Misses        853      844       -9     
Flag Coverage Δ
cpp 91.90% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.85% <ø> (ø)
datacell 92.76% <ø> (+0.41%) ⬆️
index 91.10% <100.00%> (ø)
simd 87.95% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2372ef...05d2cc8. Read the comment docs.

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
LHT129 merged commit cc047ce into antgroup:main Mar 5, 2025
jiacai2050 pushed a commit to jiacai2050/vsag that referenced this pull request Mar 6, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129
LHT129 deleted the hgraph_ef branch May 21, 2025 02:04
LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 needs-cherry-pick-release-0.13 size/XS version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hgraph recall is much lower than hnsw when ef_search small

3 participants