Skip to content

fix comiple error due to dependency missing of spdlog#480

Merged
inabao merged 1 commit into
mainfrom
fix-compile-error
Mar 5, 2025
Merged

fix comiple error due to dependency missing of spdlog#480
inabao merged 1 commit into
mainfrom
fix-compile-error

Conversation

@inabao

@inabao inabao commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

@inabao inabao added the kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 label Mar 5, 2025
@inabao
inabao requested review from jiaweizone and wxyucs March 5, 2025 07:52
@inabao inabao self-assigned this Mar 5, 2025
@inabao
inabao requested a review from LHT129 as a code owner March 5, 2025 07:52

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
inabao force-pushed the fix-compile-error branch from bfa98e0 to 28e145e Compare March 5, 2025 07:58
@inabao inabao changed the title add dependency of spdlog to io fix comiple error due to dependency missing of spdlog Mar 5, 2025
@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   91.83%   91.72%   -0.11%     
==========================================
  Files         168      168              
  Lines       10444    10431      -13     
==========================================
- Hits         9591     9568      -23     
- Misses        853      863      +10     
Flag Coverage Δ
cpp 91.72% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.76% <ø> (-0.10%) ⬇️
datacell 92.29% <100.00%> (-0.06%) ⬇️
index 90.92% <ø> (-0.18%) ⬇️
simd 87.95% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533ea8c...28e145e. Read the comment docs.

@inabao
inabao merged commit ff7ccb2 into main Mar 5, 2025
@inabao
inabao deleted the fix-compile-error branch March 5, 2025 12:55
jiacai2050 pushed a commit to jiacai2050/vsag that referenced this pull request Mar 6, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compiled the code fatal error: spdlog/spdlog.h: No such file or directory

3 participants