Skip to content

remove unnecessary code for filter#501

Merged
inabao merged 1 commit into
mainfrom
remove-unnecessary-code
Mar 13, 2025
Merged

remove unnecessary code for filter#501
inabao merged 1 commit into
mainfrom
remove-unnecessary-code

Conversation

@inabao

@inabao inabao commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inabao inabao added the version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO label Mar 13, 2025

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Mar 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   91.86%   91.91%   +0.04%     
==========================================
  Files         173      173              
  Lines       10525    10525              
==========================================
+ Hits         9669     9674       +5     
+ Misses        856      851       -5     
Flag Coverage Δ
cpp 91.91% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.93% <ø> (-0.10%) ⬇️
datacell 93.62% <ø> (+0.45%) ⬆️
index 90.94% <ø> (-0.04%) ⬇️
simd 87.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593344a...93a27c9. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inabao
inabao merged commit 84bcc09 into main Mar 13, 2025
@inabao
inabao deleted the remove-unnecessary-code branch March 13, 2025 09:12
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants