Skip to content

fix the issue where train_data_type_ is not initialized#554

Merged
inabao merged 1 commit into
mainfrom
fix-init-error-train-data-type
Apr 7, 2025
Merged

fix the issue where train_data_type_ is not initialized#554
inabao merged 1 commit into
mainfrom
fix-init-error-train-data-type

Conversation

@inabao

@inabao inabao commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

fixed: #550

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao self-assigned this Apr 2, 2025
@inabao
inabao requested review from jiaweizone and wxyucs as code owners April 2, 2025 12:39
@mergify mergify Bot added the module/tools label Apr 2, 2025
@inabao inabao added the kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 label Apr 2, 2025
@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   90.83%   90.78%   -0.05%     
==========================================
  Files         187      187              
  Lines       11398    11398              
==========================================
- Hits        10353    10348       -5     
- Misses       1045     1050       +5     
Flag Coverage Δ
cpp 90.78% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 95.21% <ø> (-0.10%) ⬇️
datacell 92.42% <ø> (ø)
index 89.17% <ø> (-0.08%) ⬇️
simd 87.31% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7487ce...b78bdd2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inabao inabao added the version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO label Apr 3, 2025

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}
}

try {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: the method EvalDataset::Load is too long

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inabao
inabao merged commit 27f6916 into main Apr 7, 2025
@inabao
inabao deleted the fix-init-error-train-data-type branch April 7, 2025 12:10
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 module/tools size/M version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evaluating performance using eval_performance on the IP dataset will causes a core dump.

3 participants