Skip to content

fix rabitq recall decrease#565

Merged
wxyucs merged 1 commit into
antgroup:mainfrom
LHT129:fix_rabitq
Apr 8, 2025
Merged

fix rabitq recall decrease#565
wxyucs merged 1 commit into
antgroup:mainfrom
LHT129:fix_rabitq

Conversation

@LHT129

@LHT129 LHT129 commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

fixed: #564

  • initialize the memory before rabitq encode

- initialize the memory before rabitq encode

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换 needs-cherry-pick-release-0.14 labels Apr 8, 2025
@LHT129
LHT129 requested review from inabao and wxyucs April 8, 2025 06:24
@LHT129 LHT129 self-assigned this Apr 8, 2025
@LHT129
LHT129 requested a review from ShawnShawnYou as a code owner April 8, 2025 06:24

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Apr 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   90.80%   90.86%   +0.06%     
==========================================
  Files         187      187              
  Lines       11429    11430       +1     
==========================================
+ Hits        10378    10386       +8     
+ Misses       1051     1044       -7     
Flag Coverage Δ
cpp 90.86% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.78% <ø> (ø)
datacell 92.47% <100.00%> (+0.09%) ⬆️
index 89.38% <ø> (+0.07%) ⬆️
simd 87.31% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1790dda...cdef7ee. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wxyucs
wxyucs merged commit 632d02b into antgroup:main Apr 8, 2025
@wxyucs wxyucs changed the title fix rabitq recall fix rabitq recall decrease Apr 8, 2025
wxyucs pushed a commit that referenced this pull request Apr 8, 2025
- initialize the memory before rabitq encode

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129
LHT129 deleted the fix_rabitq branch May 21, 2025 02:05
LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
- initialize the memory before rabitq encode

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
- initialize the memory before rabitq encode

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
- initialize the memory before rabitq encode

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-0.14-done kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 needs-cherry-pick-release-0.14 size/XS version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the recall of rabitq on the GIST-1M dataset is too low

3 participants