Skip to content

fix coredump when searching empty index#577

Merged
inabao merged 3 commits into
mainfrom
fix-coredump
Apr 10, 2025
Merged

fix coredump when searching empty index#577
inabao merged 3 commits into
mainfrom
fix-coredump

Conversation

@inabao

@inabao inabao commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

fixed: #576

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 needs-cherry-pick-release-0.14 labels Apr 9, 2025
@inabao inabao self-assigned this Apr 9, 2025
inabao added 2 commits April 9, 2025 22:32
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@codecov

codecov Bot commented Apr 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   90.84%   90.82%   -0.03%     
==========================================
  Files         189      189              
  Lines       11511    11517       +6     
==========================================
+ Hits        10457    10460       +3     
- Misses       1054     1057       +3     
Flag Coverage Δ
cpp 90.82% <68.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.78% <ø> (ø)
datacell 92.40% <ø> (-0.05%) ⬇️
index 89.26% <68.75%> (-0.05%) ⬇️
simd 87.24% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ae031...133e3ab. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao
inabao merged commit 9e7c5f3 into main Apr 10, 2025
@inabao
inabao deleted the fix-coredump branch April 10, 2025 03:11
wxyucs pushed a commit that referenced this pull request Apr 10, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-0.14-done kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 module/testing needs-cherry-pick-release-0.14 size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version 0.14 coredump at vsag::FP32Quantizer<(vsag::MetricType)1>::ComputeDistImpl

4 participants