Skip to content

[bugfix][hgraph] fix core on large dataset build#588

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:bugfix
Apr 15, 2025
Merged

[bugfix][hgraph] fix core on large dataset build#588
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:bugfix

Conversation

@LHT129

@LHT129 LHT129 commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator

fixed: #591

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 needs-cherry-pick-release-0.13 version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换 needs-cherry-pick-release-0.14 labels Apr 15, 2025
@LHT129
LHT129 requested review from inabao and wxyucs April 15, 2025 06:06
@LHT129 LHT129 self-assigned this Apr 15, 2025
@codecov

codecov Bot commented Apr 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   90.91%   90.83%   -0.08%     
==========================================
  Files         189      189              
  Lines       11524    11525       +1     
==========================================
- Hits        10477    10469       -8     
- Misses       1047     1056       +9     
Flag Coverage Δ
cpp 90.83% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 94.78% <ø> (ø)
datacell 92.40% <100.00%> (+<0.01%) ⬆️
index 89.32% <ø> (-0.15%) ⬇️
simd 87.24% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbf335...25c8331. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129
LHT129 marked this pull request as ready for review April 15, 2025 07:57
@LHT129
LHT129 requested a review from ShawnShawnYou as a code owner April 15, 2025 07:57

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
LHT129 merged commit 4c9faf2 into antgroup:main Apr 15, 2025
@LHT129
LHT129 deleted the bugfix branch April 15, 2025 08:48
wxyucs pushed a commit that referenced this pull request Apr 16, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@wxyucs wxyucs added cherry-pick-0.14-done version/0.13 1. Add bruteforce 2. Implement pyramid 1. 新增 bruteforce 2. pyramid 功能实现 version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO and removed needs-cherry-pick-release-0.13 labels Apr 16, 2025
LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-0.14-done kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 needs-cherry-pick-release-0.14 size/XS version/0.13 1. Add bruteforce 2. Implement pyramid 1. 新增 bruteforce 2. pyramid 功能实现 version/0.14 1. Add IVF 2. Add Sparse 3. Async IO 1. 新增 IVF 2. 增加 Sparse 3. 异步 IO version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A core dump caused by a narrow cast

4 participants