Support io direct read cross blocks#60
Merged
Merged
Conversation
LHT129
added
the
kind/feature
LHT129
force-pushed
the
cross_block_read
branch
from
October 11, 2024 09:06
799babe to
5ccf4a8
Compare
jiaweizone
reviewed
Oct 11, 2024
| GetCodesById(uint64_t id, bool& need_release) const override; | ||
|
|
||
| bool | ||
| GetCodesById(uint8_t* codes, uint64_t id) const override; |
Collaborator
There was a problem hiding this comment.
Adjust the params sequence: Input before output
Comment on lines
157
to
158
| if (check_valid_offset(size + offset)) { | ||
| if (check_in_one_block(offset, size + offset)) { |
Collaborator
There was a problem hiding this comment.
unify name style: checkValidOffset / checkInOneBlock (like memory_io.h:112)
Collaborator
Author
There was a problem hiding this comment.
we use under line style for private function. the memory_io.h will be fixed by other pull request
LHT129
force-pushed
the
cross_block_read
branch
3 times, most recently
from
October 14, 2024 06:30
aa9bf1d to
4890963
Compare
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
force-pushed
the
cross_block_read
branch
from
October 14, 2024 07:48
4890963 to
f3bc4c3
Compare
jiaweizone
approved these changes
Oct 14, 2024
| const uint8_t* | ||
| FlattenDataCell<QuantTmpl, IOTmpl>::GetCodesById(uint64_t id) const { | ||
| return io_->Read(code_size_, id * code_size_); | ||
| FlattenDataCell<QuantTmpl, IOTmpl>::GetCodesById(uint64_t id, bool& need_release) const { |
Collaborator
There was a problem hiding this comment.
add TODO to simplify memory management
Roxanne0321
pushed a commit
to Roxanne0321/vsag
that referenced
this pull request
Mar 3, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #40