fix compatibility of hnsw#624
Merged
Merged
Conversation
inabao
added
kind/bug
Codecov ReportAttention: Patch coverage is ❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 91.05% 91.33% +0.27%
==========================================
Files 180 180
Lines 10658 10774 +116
==========================================
+ Hits 9705 9840 +135
+ Misses 953 934 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jiaweizone
reviewed
Apr 23, 2025
| auto read_size = sizeof(InnerIdType) + sizeof(size_t); | ||
| vsag::Vector<char> buffer(buffer_size, allocator_); | ||
| reader.Read(buffer.data(), read_size); | ||
| enterpoint_node_ = *(InnerIdType*)(buffer.data() + 0); |
wxyucs
requested changes
Apr 24, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
inabao
force-pushed
the
fix-compatibility
branch
from
April 28, 2025 03:33
4865cdc to
4cfa439
Compare
jiaweizone
reviewed
Apr 29, 2025
jiaweizone
approved these changes
Apr 30, 2025
| * Compatibility Logic Flow: | ||
| * 1. Try reading newer format (12 bytes) | ||
| * 2. If validation fails (M_ != maxM_), | ||
| * 3. Read older format (16 bytes) as fallback |
Collaborator
There was a problem hiding this comment.
OK，in next version we can change to detect file version first
Collaborator
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed: #623