use DistanceHeap replace MaxHeap#680
Merged
Merged
Conversation
LHT129
added
the
kind/improvement
LHT129
added
the
version/0.15
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 91.29% 91.34% +0.04%
==========================================
Files 189 189
Lines 11422 11421 -1
==========================================
+ Hits 10428 10432 +4
+ Misses 994 989 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LHT129
force-pushed
the
heap
branch
2 times, most recently
from
May 10, 2025 02:54
9f80cb8 to
735aca6
Compare
inabao
reviewed
May 10, 2025
| IteratorFilterContext* iter_ctx) const { | ||
| MaxHeap top_candidates(allocator_); | ||
| MaxHeap candidate_set(allocator_); | ||
| auto top_candidates = std::make_shared<StandardHeap<true, false>>(allocator_, -1); |
Collaborator
There was a problem hiding this comment.
can we initialize a size here?
Collaborator
Author
There was a problem hiding this comment.
origin MaxHeap not fixed size, so we only replace with non-fixed-size StandardHeap
ShawnShawnYou
approved these changes
May 12, 2025
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
added a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.