Skip to content

resolve initialization order issue for static variables#682

Merged
inabao merged 3 commits into
mainfrom
static-initialize
May 13, 2025
Merged

resolve initialization order issue for static variables#682
inabao merged 3 commits into
mainfrom
static-initialize

Conversation

@inabao

@inabao inabao commented May 6, 2025

Copy link
Copy Markdown
Collaborator

fixed: #681

@inabao inabao added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换 labels May 6, 2025
@inabao
inabao requested a review from LHT129 May 6, 2025 08:42
@inabao inabao self-assigned this May 6, 2025
@inabao
inabao requested a review from wxyucs as a code owner May 6, 2025 08:42
@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   91.63%   91.53%   -0.10%     
==========================================
  Files         187      189       +2     
  Lines       11352    11394      +42     
==========================================
+ Hits        10402    10430      +28     
- Misses        950      964      +14     
Flag Coverage Δ
cpp 91.53% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.10% <ø> (ø)
datacell 92.38% <ø> (-0.65%) ⬇️
index 89.63% <100.00%> (+0.04%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d6001...ccca05c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@inabao
inabao force-pushed the static-initialize branch from c422f70 to 0bcd723 Compare May 9, 2025 06:43
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
inabao force-pushed the static-initialize branch from 0bcd723 to 33296a2 Compare May 10, 2025 09:21
inabao added 2 commits May 10, 2025 18:32
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao
inabao requested a review from ShawnShawnYou as a code owner May 10, 2025 14:10

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao
inabao merged commit 3128592 into main May 13, 2025
@inabao
inabao deleted the static-initialize branch May 13, 2025 09:26
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 size/L version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换

Projects

None yet

Development

Successfully merging this pull request may close these issues.

different initialization order of static variables causes ASAN errors

3 participants