Skip to content

make the member access of Resource private#728

Merged
inabao merged 1 commit into
mainfrom
make-private
May 21, 2025
Merged

make the member access of Resource private#728
inabao merged 1 commit into
mainfrom
make-private

Conversation

@inabao

@inabao inabao commented May 19, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@inabao inabao self-assigned this May 19, 2025
@inabao inabao added the kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 label May 19, 2025
@codecov

codecov Bot commented May 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   90.95%   91.06%   +0.11%     
==========================================
  Files         190      190              
  Lines       11757    11757              
==========================================
+ Hits        10694    10707      +13     
+ Misses       1063     1050      -13     
Flag Coverage Δ
cpp 91.06% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.24% <ø> (+0.17%) ⬆️
datacell 92.41% <ø> (+0.03%) ⬆️
index 88.63% <100.00%> (+0.11%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95828a6...1341cdb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs added the version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换 label May 21, 2025

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao
inabao merged commit cd9215a into main May 21, 2025
@inabao
inabao deleted the make-private branch May 21, 2025 08:30
dasurax pushed a commit to dasurax/vsag that referenced this pull request Jun 9, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: suguan.dx <suguan.dx@antgroup.con>
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 size/XS version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants