Skip to content

use specified commit of thread_pool instead of master branch#792

Merged
wxyucs merged 1 commit into
mainfrom
fix-thirdparty-threadpool-version-inconsistent
Jun 11, 2025
Merged

use specified commit of thread_pool instead of master branch#792
wxyucs merged 1 commit into
mainfrom
fix-thirdparty-threadpool-version-inconsistent

Conversation

@wxyucs

@wxyucs wxyucs commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

fixes: #781

Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
@wxyucs wxyucs self-assigned this Jun 11, 2025
@wxyucs
wxyucs requested a review from jiaweizone as a code owner June 11, 2025 07:58
@wxyucs wxyucs added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换 labels Jun 11, 2025

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jun 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   89.18%   89.25%   +0.06%     
==========================================
  Files         210      210              
  Lines       13504    13504              
==========================================
+ Hits        12044    12053       +9     
+ Misses       1460     1451       -9     
Flag Coverage Δ
cpp 89.25% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.74% <ø> (+0.08%) ⬆️
datacell 91.55% <ø> (ø)
index 89.91% <ø> (+0.12%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f63108...899a5a6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jiaweizone jiaweizone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FetchContent_Declare(
thread_pool
URL https://github.com/log4cplus/ThreadPool/archive/refs/heads/master.tar.gz
URL https://github.com/log4cplus/ThreadPool/archive/3507796e172d36555b47d6191f170823d9f6b12c.tar.gz

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,change to special commit version to avoid MD5 check issue

@wxyucs
wxyucs merged commit c7636aa into main Jun 11, 2025
22 of 23 checks passed
@wxyucs
wxyucs deleted the fix-thirdparty-threadpool-version-inconsistent branch June 11, 2025 14:44
LHT129 pushed a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
…p#792)

Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
LHT129 pushed a commit that referenced this pull request May 11, 2026
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
…p#792)

Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 size/XS version/0.15 1. Add Attribute Filter 2. Quantization and transformation 1. 新增 Attribute Filter 2. 量化与变换

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependence download error

4 participants