refactored attribute to remove c++17 dependency in the interface#803
Merged
Conversation
wxyucs
added
the
kind/improvement
wxyucs
requested review from
LHT129,
ShawnShawnYou,
inabao and
jiaweizone
as code owners
June 16, 2025 03:48
wxyucs
added
the
version/0.15
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 91.47% 91.57% +0.09%
==========================================
Files 212 216 +4
Lines 13590 13674 +84
==========================================
+ Hits 12432 12522 +90
+ Misses 1158 1152 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jiaweizone
reviewed
Jun 16, 2025
| GetValueCount() const override; | ||
|
|
||
| public: | ||
| std::vector<T> value_{}; |
Collaborator
There was a problem hiding this comment.
value_ is public field ?
rename to value ?
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
wxyucs
force-pushed
the
fix-interface-require-cxx17
branch
from
June 18, 2025 02:47
1c3b303 to
0424481
Compare
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
…group#803) Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
…group#803) Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.