use antlr4's static library instead of dynamic library#830
Merged
Conversation
wxyucs
commented
Jun 23, 2025
wxyucs
commented
Collaborator
- compile static library of the thirdparty antlr4
- compile the gen codes with static library
- compile static library of the thirdparty antlr4 - compile the gen codes with static library Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
wxyucs
added
the
kind/improvement
wxyucs
added
the
version/0.15
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #830 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 225 225
Lines 14279 14279
=======================================
Hits 13021 13021
Misses 1258 1258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
- compile static library of the thirdparty antlr4 - compile the gen codes with static library Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
- compile static library of the thirdparty antlr4 - compile the gen codes with static library Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
- compile static library of the thirdparty antlr4 - compile the gen codes with static library Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.