fix coredump in hgraph when using empty parameter#885
Merged
Conversation
inabao
added
kind/bug
inabao
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #885 +/- ##
==========================================
+ Coverage 90.08% 90.36% +0.27%
==========================================
Files 224 224
Lines 15026 15026
==========================================
+ Hits 13536 13578 +42
+ Misses 1490 1448 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LHT129
reviewed
Jul 4, 2025
| "{SQ4_UNIFORM_QUANTIZATION_TRUNC_RATE}": 0.05, | ||
| "{PCA_DIM}": 0, | ||
| "{PRODUCT_QUANTIZATION_DIM}": 0 | ||
| "{PRODUCT_QUANTIZATION_DIM}": 32 |
Collaborator
There was a problem hiding this comment.
1 is better, some times dim may lower than 32
Collaborator
|
@inabao this pull request cannot cherry-pick to 0.15, because there is a merge conflict, please create a new pull request to branch 0.15 |
jingyueob
pushed a commit
to jingyueob/vsag
that referenced
this pull request
Jul 15, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: jingyue.zjl <jingyue.zjl@oceanbase.com>
LHT129
pushed a commit
to LHT129/vsag
that referenced
this pull request
Apr 16, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
LHT129
pushed a commit
that referenced
this pull request
May 11, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland
pushed a commit
to Sia-Sheerland/vsag
that referenced
this pull request
Jun 26, 2026
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com> Signed-off-by: Sia Sheerland <x1075956441x@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed: #883