Skip to content

support update attribute#916

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:update_attr
Jul 22, 2025
Merged

support update attribute#916
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:update_attr

Conversation

@LHT129

@LHT129 LHT129 commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

closed: #917

@LHT129 LHT129 self-assigned this Jul 10, 2025
@LHT129
LHT129 requested review from inabao and wxyucs as code owners July 10, 2025 07:31
@LHT129 LHT129 added the kind/feature Brand-new functionality or capabilities 引入全新的功能、新特性或新能力 label Jul 10, 2025
@LHT129 LHT129 added the version/0.16 1. Add SINDI 2. Extend HGraph 1. 新增SINDI 2. 扩展 HGraph label Jul 10, 2025
@gemini-code-assist

gemini-code-assist Bot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@codecov

codecov Bot commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 48.36066% with 63 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (48.36%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   90.66%   90.52%   -0.14%     
==========================================
  Files         283      283              
  Lines       16308    16343      +35     
==========================================
+ Hits        14785    14794       +9     
- Misses       1523     1549      +26
Flag Coverage Δ
cpp 90.52% <48.36%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 91.64% <ø> (ø)
datacell 91.35% <57.14%> (-0.60%) ⬇️
index 88.54% <42.85%> (-0.14%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e55555...6c4936f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129
LHT129 force-pushed the update_attr branch 3 times, most recently from 560367c to a89343b Compare July 11, 2025 02:27
inabao
inabao approved these changes Jul 14, 2025
View reviewed changes

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
LHT129 force-pushed the update_attr branch 3 times, most recently from 2081969 to 93c4f3f Compare July 18, 2025 09:33
@LHT129
support update attribute
6c4936f 
- remove xor operator (no used now)

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
wxyucs
wxyucs approved these changes Jul 22, 2025
View reviewed changes

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129
LHT129 merged commit 49d186b into antgroup:main Jul 22, 2025
22 of 23 checks passed
@gemini-code-assist

gemini-code-assist Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
@LHT129
support update attribute (antgroup#916)
444e546 
- remove xor operator (no used now)

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
@LHT129
support update attribute (#916)
5e2d4b7 
- remove xor operator (no used now)

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
@LHT129
support update attribute (antgroup#916)
214b045 
- remove xor operator (no used now)

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxyucs wxyucs wxyucs approved these changes
@inabao inabao inabao approved these changes
@ShawnShawnYou ShawnShawnYou ShawnShawnYou approved these changes
@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@LHT129 LHT129

Labels

kind/feature Brand-new functionality or capabilities 引入全新的功能、新特性或新能力 size/XL version/0.16 1. Add SINDI 2. Extend HGraph 1. 新增SINDI 2. 扩展 HGraph

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Update(without old value) for attributes in IVF index

4 participants

@LHT129 @wxyucs @inabao @ShawnShawnYou