Skip to content

fix header include error#995

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:fix
Jul 31, 2025
Merged

fix header include error#995
LHT129 merged 1 commit into
antgroup:mainfrom
LHT129:fix

Conversation

@LHT129

@LHT129 LHT129 commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator

closed: #996

Summary by Sourcery

Bug Fixes:

  • Add missing 'attr/argparse.h' include and remove stale 'attr/expression_visitor.h' include in brute_force.cpp to resolve header include error

@LHT129 LHT129 self-assigned this Jul 31, 2025
@LHT129
LHT129 requested review from inabao and wxyucs as code owners July 31, 2025 03:06
@LHT129 LHT129 added kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 version/0.16 1. Add SINDI 2. Extend HGraph 1. 新增SINDI 2. 扩展 HGraph labels Jul 31, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@sourcery-ai

sourcery-ai Bot commented Jul 31, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR corrects header dependencies in brute_force.cpp by adding a missing argparse include, removing an obsolete expression visitor include, and ensuring consistent include ordering.

File-Level Changes

Change Details Files
Fixed missing and redundant header includes
  • Added include for attr/argparse.h to satisfy missing dependency
  • Removed obsolete attr/expression_visitor.h include
  • Adjusted include order for consistency
src/algorithm/brute_force.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LHT129 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LHT129

LHT129 commented Jul 31, 2025

Copy link
Copy Markdown
Collaborator Author

@sourcery-ai issue

@sourcery-ai

sourcery-ai Bot commented Jul 31, 2025

Copy link
Copy Markdown

I've noted your request to create a GitHub issue from the review comment. However, I don't have the ability to directly create issues myself. You can manually create an issue referencing the reviewer's guide or any specific feedback from this PR. If you need a summary or specific content to include in the issue, let me know and I can generate that for you!

@inabao inabao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wxyucs wxyucs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   91.92%   91.77%   -0.15%     
==========================================
  Files         293      294       +1     
  Lines       17020    17069      +49     
==========================================
+ Hits        15645    15665      +20     
- Misses       1375     1404      +29     
Flag Coverage Δ
cpp 91.77% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.51% <ø> (ø)
datacell 91.46% <100.00%> (-0.50%) ⬇️
index 90.66% <96.15%> (-0.05%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ae75a...f79a393. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LHT129
LHT129 merged commit 288fe51 into antgroup:main Jul 31, 2025
28 of 31 checks passed
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

LHT129 added a commit to LHT129/vsag that referenced this pull request Apr 16, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129 added a commit that referenced this pull request May 11, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129
LHT129 deleted the fix branch May 29, 2026 07:20
Sia-Sheerland pushed a commit to Sia-Sheerland/vsag that referenced this pull request Jun 26, 2026
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
Signed-off-by: Sia Sheerland <x1075956441x@163.com>

Signed-off-by: Sia Sheerland <x1075956441x@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Bug fixes, defects, or unexpected behavior 修复程序错误、缺陷或异常行为 module/testing size/XS version/0.16 1. Add SINDI 2. Extend HGraph 1. 新增SINDI 2. 扩展 HGraph

Projects

None yet

Development

Successfully merging this pull request may close these issues.

header file include missing

3 participants