fix(bedrock): run async SigV4 auth off the event loop - #1777
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
AsyncAnthropicBedrock._prepare_request called get_auth_headers synchronously, blocking the event loop during AWS credential resolution and SigV4 signing. Use to_thread to run it in a worker thread so concurrent async tasks keep running. Same fix applied to AsyncAnthropicBedrockMantle. Fixes anthropics#1770
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncAnthropicBedrock._prepare_requestcalledget_auth_headers()synchronously, blocking the event loop during AWS credential resolution and SigV4 signing (#1770).Fix
Wrap the call in
to_thread()(fromanthropic._utils._sync) so credential work runs in a worker thread. Same fix applied toAsyncAnthropicBedrockMantle.Test
Added
test_bedrock_async_thread.py— asserts concurrent heartbeats keep firing while auth is slow.Fixes #1770