Remove checks for project_id in load_auth() - #468
Closed
ushuz wants to merge 1 commit into
Closed
Conversation
Collaborator
RobertCraigie
removed their request for review
May 22, 2024 12:52
stainless-app Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
… from the package root (#468) Co-authored-by: Claude <noreply@anthropic.com>
Merged
stainless-app Bot
pushed a commit
that referenced
this pull request
Aug 19, 2026
… from the package root (#468) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnthropicVertexacceptsproject_idfrom the caller. So whetherload_auth()could load theproject_idfrom the Google credential should not be a hard requirement.Right now, if
load_auth()can't load theproject_id, it raisesValueErrorand aborts any further execution.