Fix thinking checkpoint rebuild on length stop - #77
Merged
antirez merged 1 commit intoMay 11, 2026
Merged
Conversation
Length-stopped chat/thinking requests were synchronously rebuilding the
thinking checkpoint before returning the response. Skip canonicalization for
incomplete thinking turns so client wall time reflects the sampled response.
Client results before the patch:
Context | Prompt TPS | Gen TPS | Gen Tokens | Total Time
--------|------------|---------|------------|------------
0.5k | 230.0 | 23.6 | 128 | 7.3s
1k | 296.5 | 20.4 | 128 | 9.0s
2k | 366.3 | 12.4 | 128 | 15.7s
4k | 308.2 | 7.4 | 128 | 30.0s
Client results after the patch:
Context | Prompt TPS | Gen TPS | Gen Tokens | Total Time
--------|------------|---------|------------|------------
0.5k | 239.1 | 38.8 | 128 | 5.2s
1k | 295.3 | 38.6 | 128 | 6.0s
2k | 357.3 | 33.2 | 128 | 9.4s
4k | 307.9 | 31.0 | 128 | 17.1s
Tested with:
make all ds4_test && make test
Owner
|
🦾 |
hexxyan
pushed a commit
to hexxyan/ds4
that referenced
this pull request
May 27, 2026
…ng-checkpoint-gate Fix thinking checkpoint rebuild on length stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #76
Length-stopped chat/thinking requests were synchronously rebuilding the thinking checkpoint before returning the response. Skip canonicalization for incomplete thinking turns so client wall time reflects the sampled response.
Client results before the patch:
Context | Prompt TPS | Gen TPS | Gen Tokens | Total Time --------|------------|---------|------------|------------
0.5k | 230.0 | 23.6 | 128 | 7.3s
1k | 296.5 | 20.4 | 128 | 9.0s
2k | 366.3 | 12.4 | 128 | 15.7s
4k | 308.2 | 7.4 | 128 | 30.0s
Client results after the patch:
Context | Prompt TPS | Gen TPS | Gen Tokens | Total Time --------|------------|---------|------------|------------
0.5k | 239.1 | 38.8 | 128 | 5.2s
1k | 295.3 | 38.6 | 128 | 6.0s
2k | 357.3 | 33.2 | 128 | 9.4s
4k | 307.9 | 31.0 | 128 | 17.1s
Tested with:
make all ds4_test && make test