Add test for single address SETAASA#44
Merged
Merged
Conversation
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
Signed-off-by: Karol Gugala <kgugala@antmicro.com>
Addresses below 0x8 are reserved in I2C and should not be used for static addresses. Signed-off-by: Karol Gugala <kgugala@antmicro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test where SETAASA should set only one of the virtual/main dynamic addresses because the other dynamic address is previously set using CSR writes. It also updates the list of alid addresses to exclude I2C addresses which are not allowed as static addresses, this aligns list of tested valid addresses with RTL implementation: https://github.com/antmicro/i3c-core/blob/v1p5-msft/src/i3c_pkg.sv#L60-L64.