Editorial: name the chosen accuracy |choice|, not |permission| - #2
Merged
antosart merged 2 commits intoJul 30, 2026
Merged
Conversation
marcoscaceres
force-pushed
the
fix/geo-233-choice-rename
branch
from
July 30, 2026 01:34
787c8b8 to
dda18bc
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the local variable
|permission|to|choice|in the acquire-a-position and request-a-position algorithms: it holds the result of "prompt the user to choose", which is either "denied" or the chosenAccuracyMode, so|permission|misleadingly reads as a grant/deny state when it actually carries the accuracy selection (this matches the Permissions spec's own wording, "the user's selection"). Also fixes aTy→Trytypo and aligns the emulated-position construction call's argument punctuation with the main call.