Skip to content

fix(chart-advisor): uninitialize noDataLayer#78

Merged
neoddish merged 2 commits into
antvis:masterfrom
AceLeeWinnie:fix-noDataLayer
Aug 10, 2020
Merged

fix(chart-advisor): uninitialize noDataLayer#78
neoddish merged 2 commits into
antvis:masterfrom
AceLeeWinnie:fix-noDataLayer

Conversation

@AceLeeWinnie

Copy link
Copy Markdown
Contributor

重复调用 autoChart 时,destroy noDataLayer 后未初始化,导致再次调用 destroy 失败。

@auto-add-label auto-add-label Bot added the bug Something isn't working label Aug 4, 2020

@tests-checker tests-checker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@neoddish neoddish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR: merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants