Skip to content

Release - #2070

Merged
wang1212 merged 2 commits into
masterfrom
release
Oct 13, 2025
Merged

Release#2070
wang1212 merged 2 commits into
masterfrom
release

Conversation

@wang1212

Copy link
Copy Markdown
Member

No description provided.

wang1212 and others added 2 commits October 13, 2025 20:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Oct 13, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b5397a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a routine release that propagates a critical type definition fix from the core @antv/g-lite package across the entire @antv/g-* ecosystem. It ensures that all dependent packages are updated to consume the corrected core library, maintaining consistency and stability throughout the project.

Highlights

  • Version Bumps Across Packages: This pull request updates the version numbers for numerous @antv/g-* packages to their latest patch releases, including @antv/g-camera-api to 2.0.43, @antv/g-canvas to 2.0.50, @antv/g-lite to 2.4.1, and many others.
  • Core Type Definition Fix in g-lite: The @antv/g-lite package, a core module, received a patch update (2.4.1) to fix a type definition issue, specifically modifying the CustomEvent type to be more flexible and adding WebXR reference types.
  • Dependency Updates: Many packages had their dependencies updated to reflect the new g-lite@2.4.1 version, ensuring all related modules are in sync with the core library's latest patch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@wang1212
wang1212 merged commit 2b52c53 into master Oct 13, 2025
4 of 5 checks passed
@wang1212
wang1212 deleted the release branch October 13, 2025 12:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be a release, primarily consisting of version bumps and changelog updates across multiple packages. The core logic change is in @antv/g-lite to fix a type definition.

My review focuses on the code changes in @antv/g-lite. I've found a potential issue in the CustomEvent type definition where it seems to incorrectly specify its base class generic parameter, which could lead to type errors and runtime issues. I've left a specific comment with a suggested fix for this.

O extends { detail?: any } = any,
> extends FederatedEvent<null, O['detail']> {
O extends { detail?: any; [key: string | number]: any } = any,
> extends FederatedEvent<Event, O['detail']> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The base class for CustomEvent is changed to FederatedEvent<Event, O['detail']>. This implies that CustomEvent instances must have a nativeEvent property of type Event.

However, CustomEvent is created programmatically and is not associated with a native browser event. Its constructor does not initialize the nativeEvent property, which will leave it undefined. This is a type mismatch (undefined is not assignable to Event) and can lead to runtime errors if nativeEvent is accessed.

The previous implementation extends FederatedEvent<null, O['detail']> was correct, as it correctly typed nativeEvent as null for custom events.

It's recommended to revert this part of the change.

Suggested change
> extends FederatedEvent<Event, O['detail']> {
> extends FederatedEvent<null, O['detail']> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant