feat: add transformer implementation - #1
Conversation
There was a problem hiding this comment.
Code Review
This pull request significantly refactors and enhances the local context retrieval library, introducing advanced features such as document chunking, hybrid search (vector + FTS text matching), synonym-based query expansion, keyword-based reranking, progress callbacks, and a robust storage manager with a pure JS memory fallback. The review feedback identifies several critical bugs and improvement opportunities in the new implementation: a query filter and slicing bug in expandChunk, incorrect heading path tracking for sibling H3 headings in the Markdown chunker, a word boundary checking limitation in both the keyword reranker and synonym expander that only evaluates the first occurrence of a term, and swallowed error details during document loading.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
保持代码和功能最简,diff 能不能减少到 3 |
已修改。 |
| @@ -0,0 +1,407 @@ | |||
| /** | |||
There was a problem hiding this comment.
再检查下这个类,是必须的吗,我看代码就是把 zvec 的方法代理了一遍?有些方法还没用到,比如 searchHybridSync。
No description provided.