Skip to content

Conversation

@ignatovv
Copy link
Member

No description provided.

mgolovko and others added 30 commits October 29, 2025 14:18
…or-migrate-to-observable

iOS-5385 Core | Application coordinator migrate to observable
…sses-where-we-are-using-injection

iOS-5401 Core | migrate struct to classes where we are using injection
IOS-5364 Update workflow documentation for test_fastlane_build and ipa workflows
Co-authored-by: William Blake <iosteam@anytype.io>
IOS-5415 Add dependency injection in structs guideline to code review
…tor-chat-view-to-observable

IOS-5388 Core | Migrate chat coordinator to @observable
Co-authored-by: Vova Ignatov <ignatovv@users.noreply.github.com>
IOS-5415 Add code review guidelines reference to CLAUDE.md
…s-menu-converted-to-project

IOS-5255 Update Object Settings Menu
…nels-in-settings-row-and-spaces-screen

IOS-5417 Spaces -> Channels
Replaced Combine publishers with withObservationTracking for manual observation of nested @observable objects. Changes include:
- Removed Combine dependency and cancellables
- Updated @StateObject to @State in views
- Converted @published properties to regular properties
- Added @ObservationIgnored to injected dependencies and non-observed properties
- Implemented manual observation pattern using withObservationTracking for settings and actions
…-with-in-the-link-and-does-not-open-on

IOS-5500 remove encoding for published pages
…should-have-the-chat-name-in-the-header

IOS-5504 Show chat name in header for multi-chat spaces
…ng-in-bin-release

Ios 5503 restricted chat editing in bin release
…uploading-converted-to-project

IOS-5054 Disabled showUploadStatusIndicator
IOS-5508 Fix TestFlight upload bundle ID selection in Xcode 26
…-chat-query-and-chat-type-widget-the

IOS-5499 Fix creator titles
…licated-in-the-chat-preview

IOS-5515 Fix duplicated user name in chat preview with attachments
@ignatovv ignatovv requested a review from a team as a code owner November 26, 2025 11:52
@socket-security
Copy link

socket-security bot commented Nov 26, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedfastlane@​2.224.0 ⏵ 2.229.170 +4100100100100

View full report

@claude
Copy link
Contributor

claude bot commented Nov 26, 2025

Best Practices

.github/workflows/update_middleware.yaml:38
Runner version mismatch. The workflow comment at the top of this file should document that runs-on: macos-26 requires Xcode 26.1 according to the mapping in .github/workflows/pr-review-automation.md. This is correctly implemented (line 109: xcode-version: '26.1') but the documentation header (lines 1-14) doesn't mention the macOS/Xcode version mapping.

Anytype/Sources/Analytics/AnytypeAnalytics/AnytypeAnalytics.swift:107
The new logEvent method has a default parameter addActiveSpaceInfo: Bool = true which changes behavior for all existing callers. This is a breaking change - existing calls that previously went directly to event logging now conditionally add space info. Consider:

  • Auditing all callers to ensure this new behavior is intended
  • Or rename the method to make the behavioral change explicit (e.g., logEventWithSpace)

⚠️ Minor Issues - Document runner/Xcode mapping and review analytics behavior change

…ease-to-main

# Conflicts:
#	Anytype.xcodeproj/project.pbxproj
#	Anytype/Sources/PresentationLayer/Modules/HomeWidgets/Widgets/SpaceChat/SpaceChatWidgetView.swift
#	Libraryfile
#	Modules/Loc/Sources/Loc/Resources/Auth.xcstrings
#	Modules/ProtobufMessages/Sources/Protocol/Commands/Anytype_Rpc.File.SetAutoDownload.swift
#	Modules/ProtobufMessages/Sources/Protocol/Commands/Anytype_Rpc.PushNotification.Mode.swift
#	Modules/ProtobufMessages/Sources/Protocol/Commands/Anytype_Rpc.PushNotification.ResetIds.swift
#	Modules/ProtobufMessages/Sources/Protocol/Commands/Anytype_Rpc.PushNotification.SetForceModeIds.swift
#	Modules/ProtobufMessages/Sources/Protocol/Commands/Anytype_Rpc.Space.InviteView.swift
#	Modules/ProtobufMessages/Sources/Protocol/Events/Anytype_Event.Membership.TiersUpdate.swift
#	Modules/ProtobufMessages/Sources/Protocol/Events/Anytype_Event.Space.SyncStatus.swift
#	Modules/ProtobufMessages/Sources/Protocol/Models/Anytype_Model_InvitePayload.swift
@ignatovv ignatovv force-pushed the ios-5068-release-to-main branch from 47cde54 to 08ed9e9 Compare November 26, 2025 12:03
@claude
Copy link
Contributor

claude bot commented Nov 26, 2025

Bugs/Issues

.github/workflows/release_build.yaml:75
Incorrect conditional check - this step will never execute because inputs.build_anytype_app was removed in this PR (line 9 deleted the input definition), but the step still references it on line 75.

The step "Summary Anytype" should either:

  • Remove the if condition entirely (since it will always be false now), OR
  • Be removed completely if not needed

⚠️ Minor Issues - Fix conditional check in release_build workflow

@ignatovv ignatovv merged commit 1578a0b into main Nov 26, 2025
8 checks passed
@ignatovv ignatovv deleted the ios-5068-release-to-main branch November 26, 2025 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants