build: Add --nix flag to build rust in nix-shell
#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Recreation of anza-xyz#139. More information at anza-xyz/platform-tools#109, but Rust is currently built with a few additional shared libraries. #### Summary of changes Add a `--nix` flag to build.sh to optionally build with nix-shell.
LucasSte
reviewed
Oct 15, 2025
| ./x.py build --stage 1 --target ${HOST_TRIPLE},sbf-solana-solana,sbpf-solana-solana,sbpfv1-solana-solana,sbpfv2-solana-solana,sbpfv3-solana-solana,sbpfv4-solana-solana | ||
|
|
||
| if [ -n "${WITH_NIX}" ]; then | ||
| nix-shell src/tools/nix-dev-shell/shell.nix --pure --run "x build --stage 1 --target sbf-solana-solana,sbpf-solana-solana,sbpfv1-solana-solana,sbpfv2-solana-solana,sbpfv3-solana-solana,sbpfv4-solana-solana" |
Collaborator
Author
There was a problem hiding this comment.
nope! x is also a rust binary just for building in the nix environment: https://github.com/anza-xyz/rust/blob/solana-1.89.0/src/tools/nix-dev-shell/x/x.rs
LucasSte
approved these changes
Oct 16, 2025
build.sh
Outdated
Comment on lines
11
to
23
| case "$1" in | ||
| --nix) | ||
| WITH_NIX=1 | ||
| shift | ||
| ;; | ||
| --llvm) | ||
| REBUILD_LLVM=1 | ||
| shift | ||
| ;; | ||
| --help) | ||
| echo "--llvm to rebuild llvm, --nix to use nix"; | ||
| exit; | ||
| esac |
Collaborator
There was a problem hiding this comment.
This means --nix and --llvm can't be used together. I don't think this is much of a hassle, so if you are OK with that, we can merge as it is.
Collaborator
Author
There was a problem hiding this comment.
Oops sorry, you're right, wrapped this in a while loop!
LucasSte
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recreation of #139.
More information at anza-xyz/platform-tools#109, but Rust is currently built with a few additional shared libraries.
Summary of changes
Add a
--nixflag to build.sh to optionally build with nix-shell.