Update Cypress Env configuration - #4
Merged
Merged
Conversation
volarname
approved these changes
Dec 15, 2022
volarname
pushed a commit
that referenced
this pull request
Aug 7, 2026
…85491) Fixes 8 of the 10 issues from the QA report. #1 and #8 needed no code change (both are intentional: the shortestDimension filter was dead — core-dam's AssetQueryFactory never applied it — and the from/until date pair was consolidated into one AFilterTimeInterval range control that still exposes both bounds via its Custom option). - #5/#6 (blocker): drop the wrong `apiName: 'name'` on the distributionCategorySelect service-slug filter. The entity is filterable by `serviceSlug`, so `filter_*[name]` made core-dam return 500, which broke opening/creating a distribution category and the "Meno" list filter. - #7: give the anzuUser id/email/enabled/lastName filters a `type`. Without it createFilter defaults to 'custom' and FilterDetailItem renders AFilterEmpty — the bare field name with no control. - #3: add `render: { skip: true }` to the field bound in each `#search` slot, so it is no longer auto-rendered a second time in the advanced panel (11 configs). - #4: add a `#search` slot to the 7 list filters that had none, so they get a main filter bar again instead of only the "More" button; restore enable-top/#top for the mandatory `type` on both distribution-category pages, and hide-more on assetLicenceGroup. - #9: build the distribution filter store per call instead of sharing one module-level singleton. DistributionBlockedBy writes distributionServicesIn/NotIn into it and never clears them, so the create dialog's refetch emitted a self-contradictory `eq X + notIn X` query, and the sidebar list reusing the same store came back empty until a full page reload. - #10: guard JobResourceChip against an unregistered job resource — getJobResourceOption is a plain .find() and returns undefined, so `option.title` threw on /jobs. - #2: re-tint the active-filter chips from the Vuetify theme tokens in dark theme; common-admin hardcodes a white chip on a light container with no dark variant. Also updates dependencies (common-admin, vuetify, vue, tiptap, oxlint/oxfmt, cypress, vue-tsc) and applies the resulting lint/format fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New cypress configuration to support multiple environments.