fix: add terminal controls and restore copy/scroll#372
Merged
Conversation
laxmanclo
force-pushed
the
ao/reverbcode-9
branch
from
5674243 to
f1f47a9
Compare
laxmanclo
force-pushed
the
ao/reverbcode-9
branch
from
6905fc1 to
0555216
Compare
laxmanclo
changed the title
laxmanclo
changed the title
zellij 0.44.x with mouse-mode true acts on SGR wheel reports written to its stdin and scrolls the focused pane, but it does not enable host mouse reporting. xterm therefore never reports the wheel itself (protocol stays NONE) and, with scrollback:0, converts the wheel into cursor-arrow keys, which move the agent's cursor/history instead of scrolling. Synthesize SGR wheel reports from a custom wheel handler and send them through the existing input pipe; accumulate pixel deltas into line counts to match xterm's native scroll feel. Ctrl/Cmd wheel is left for the font-size zoom handler. Drag-copy is unaffected (separate selection path). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # frontend/src/main.ts
harshitsinghbhandari
force-pushed
the
ao/reverbcode-9
branch
from
12b22f4 to
5f6e509
Compare
The wheel-to-SGR translation only divided pixel deltas by row height, which is the deltaMode browsers emit for trackpads and normalized wheels (macOS). Many Linux/Windows mouse wheels report whole lines (deltaMode 1) or pages (deltaMode 2) with small deltaY, which truncated to zero lines and never scrolled. Mirror xterm's getLinesScrolled across all three modes so scroll works on every platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the terminal toolbar controls, including the + / - font size pixel controls and fullscreen toggle, while keeping the UI changes scoped to the terminal pane.
It also fixes terminal copy without relying on xterm private selection overrides. That avoids breaking normal terminal mouse behavior
For scroll, the fix ended up needing both sides: the backend now enables zellij mouse mode for embedded attach clients, and the frontend forwards xterm onData input so wheel/mouse escape sequences actually reach the mux.
Attached the tests, and tested on my linux machine, works well.