fix: keep terminal input sources explicit#383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDatabytes into the terminal muxonKeywhile keeping paste, composition, shortcut, and wheel paths intentionalRCA
PR #372 restored terminal copy/scroll behavior but reintroduced the raw xterm data stream as mux input. That can forward attach/repaint control responses into the real Codex PTY, recreating the dirty-byte corruption fixed in #325. This patch keeps the #372 intentional shortcut and wheel behavior while restoring the #325 safety boundary.
Tests
cd frontend && npm test -- XtermTerminal useTerminalSessioncd frontend && npm run typecheckNotes
Unrelated local generated/package changes were left out of this commit.