Skip to content

Resolves #78 Script to automate EC2 #96

Merged
milleruntime merged 15 commits intoapache:masterfrom
rcarterjr:clusterscript
Sep 20, 2019
Merged

Resolves #78 Script to automate EC2 #96
milleruntime merged 15 commits intoapache:masterfrom
rcarterjr:clusterscript

Conversation

@rcarterjr
Copy link
Copy Markdown
Contributor

This script implements the initial features requested. The script requires three arguments in order:

  1. URL for Accumuo git repo and a branch in that repo
  2. URL for Accumuo testing repo and a branch in that repo
  3. Local dir where muchos is setup.

I will continue working on this and adding the long term goals.

@milleruntime
Copy link
Copy Markdown
Contributor

@rcarterjr what's the status of this PR? It looks OK maybe just needs someone to test it out on a cluster?

@rcarterjr
Copy link
Copy Markdown
Contributor Author

This script now takes the args.txt as its only argument with the following inputs on their own line in the following order:

  • accumulo git repository
  • accumulo branch
  • accumuluo-testing git repository
  • accumulo-testing branch
  • fluo-muchos git repository
  • fluo-muchos branch
  • path/to/muchos.props

I will work on creating environment variables instead of having the text file and iterating through as discussed.

@rcarterjr
Copy link
Copy Markdown
Contributor Author

@milleruntime @keith-turner here are my latest changes. Let me know what you think.

Copy link
Copy Markdown
Contributor

@milleruntime milleruntime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. Just a couple minor things and then I think we can merge it.

@milleruntime
Copy link
Copy Markdown
Contributor

I will merge this up but we can continue to test and make improvements.

Copy link
Copy Markdown
Contributor

@keith-turner keith-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a quick mention in the readme with a pointer to a readme in it directory that describes how it use it.

@milleruntime milleruntime merged commit c63ea3d into apache:master Sep 20, 2019
@rcarterjr rcarterjr deleted the clusterscript branch September 20, 2019 16:27
@milleruntime
Copy link
Copy Markdown
Contributor

@rcarterjr as another follow on task, you could run ShellCheck on the script: https://github.com/koalaman/shellcheck.

@rcarterjr
Copy link
Copy Markdown
Contributor Author

Thanks Mike, that's a neat tool.

And I will write up a readme now Keith.

@keith-turner
Copy link
Copy Markdown
Contributor

And I will write up a readme now Keith.

When you do that I will try to follow the readme and run this thing. So far I have only reviewed the code script, I have not tried to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants