Resolves #78 Script to automate EC2 #96
Conversation
…into clusterscript
|
@rcarterjr what's the status of this PR? It looks OK maybe just needs someone to test it out on a cluster? |
|
This script now takes the args.txt as its only argument with the following inputs on their own line in the following order:
I will work on creating environment variables instead of having the text file and iterating through as discussed. |
|
@milleruntime @keith-turner here are my latest changes. Let me know what you think. |
milleruntime
left a comment
There was a problem hiding this comment.
Nice improvements. Just a couple minor things and then I think we can merge it.
|
I will merge this up but we can continue to test and make improvements. |
keith-turner
left a comment
There was a problem hiding this comment.
It would be nice to have a quick mention in the readme with a pointer to a readme in it directory that describes how it use it.
|
@rcarterjr as another follow on task, you could run ShellCheck on the script: https://github.com/koalaman/shellcheck. |
|
Thanks Mike, that's a neat tool. And I will write up a readme now Keith. |
When you do that I will try to follow the readme and run this thing. So far I have only reviewed the code script, I have not tried to run it. |
This script implements the initial features requested. The script requires three arguments in order:
I will continue working on this and adding the long term goals.