Tablet may write chop information to the metadata table after its closed.

[keith-turner]

Describe the bug

When CompactableImpl writes chop information here it could happen after close() was called. When a tablet calls CompactableImpl.close() it expects the call to block until all ongoing metadata writes related to compactions are complete AND prevent any new writes from occurring after the close() call returns. This expectation is not being met when writing chop information to the metadata table.

Expected behavior

CompactableImpl.close() will block if there are any ongoing metadata chop writes and prevent any new ones from starting after it returns.

[DomGarguilo]

expects the call to block until all ongoing metadata writes related to compactions are complete

For this condition I'm wondering if adding a check to the while loop in close() would account for this. Maybe something like:

fileMgr.chopStatus != FileSelectionStatus.NOT_ACTIVE

AND prevent any new writes from occurring after the close() call returns

For this condition maybe adding a check here. Something like:

if (completed && !closed)