Monitor no longer shows goal state

[ivakegg]

The monitor use to show the goal state on either the overview or the master tab. This was useful when the system is being shutdown such that everybody can see it is being shutdown. Can we add that feature back in please.

[ctubbsii]

I don't remember us having that, or removing it. What version did you see it in, and what version are you using where it's missing?

[DomGarguilo]

Looking at the Monitor code in 1.10 I see the following:

accumulo/server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/MasterServlet.java

Lines 123 to 126 in a71fa29

	if (Monitor.getMmi().state != MasterState.NORMAL) {
	sb.append("<span class='warning'>Master State: " + Monitor.getMmi().state.name() + " Goal: "
	+ Monitor.getMmi().goalState.name() + "</span>\n");
	}

Which looks like it will display on the Master page if the state from the monitors MasterMonitorInfo is other than MasterState.NORMAL.

accumulo/server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/XMLServlet.java

Line 103 in a71fa29

sb.append("\n<masterGoalState>" + Monitor.getMmi().goalState + "</masterGoalState>\n");

And this is appended to the output of the XML endpoint (which i was able to verify by standing up a 1.10 cluster and viewing)

In 2.1, it looks like that data (now managerGoalState) is still present in the MangerMonitorInfo but is never displayed on the Manger page. I think it will still be present in the /XML endpoint though (but have not yet verified).

@ivakegg does this sound right to you? If so, is the goal of this ticket to have the manager goal state displayed in the 2.1 manger page if it is not NORMAL?

[ctubbsii]

At a minimum, it should be in the REST endpoint at /xml and /json, but I'd support adding it back in to the page, too (as long as it updates when the status changes, like the other background AJAX data refreshes.

[ivakegg]

@DomGarguilo Yes you have that correct.

[DomGarguilo]

Fixed in #3389