Skip to content

Iterator parsing code is duplicated #6074

@keith-turner

Description

@keith-turner

The code for parsing iterator configuration from properties is duplicated throughout the codebase. The parsing is not consistent in its error checking.

All of this code could be refactored in the following way.

  • Create a single method that parses from properties to List<IteratorSetting> (could potentially use existing code).
  • Modify any code that is currently doing parsing to use this new method.

The centralized parsing code could validate the following.

  • A valid scope is used.
  • The value has only two fields seperated by a comma.

Any changes made should avoid impacting scan performance. Scans need to efficiently parse iterator config. For other code parsing iterator configuration, efficiency is less of a concern.

The following comment suggested a possible way to start this.

Originally posted by @keith-turner in #6040 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions