Skip to content

Commons collections#1110

Merged
milleruntime merged 1 commit intoapache:masterfrom
milleruntime:commons-collections
Apr 29, 2019
Merged

Commons collections#1110
milleruntime merged 1 commit intoapache:masterfrom
milleruntime:commons-collections

Conversation

@milleruntime
Copy link
Copy Markdown
Contributor

@milleruntime milleruntime commented Apr 18, 2019

Just get some tests running in Travis

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Apr 19, 2019

Ok looks like Travis didn't run so I will Test this bad boy locally.

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Apr 19, 2019

Tests failing so putting this on hold for now.

@milleruntime milleruntime marked this pull request as ready for review April 26, 2019 15:46
@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Apr 26, 2019

All Unit tests are passing. Haven't run the ITs yet.

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Apr 29, 2019

I think this is good finally so I will merge.

@milleruntime milleruntime merged commit 51b8644 into apache:master Apr 29, 2019
@milleruntime milleruntime deleted the commons-collections branch April 29, 2019 17:29
ctubbsii
ctubbsii reviewed Apr 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milleruntime This should update assemble/src/main/assemblies/component.xml as well.

@milleruntime
Copy link
Copy Markdown
Contributor Author

milleruntime commented Apr 30, 2019

I am seeing this warning... Is this what you are referring to?
[INFO] --- maven-assembly-plugin:3.0.0:single (binary-assembly) @ accumulo ---
[INFO] Reading assembly descriptor: src/main/assemblies/binary-release.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'commons-collections:commons-collections'

@ctubbsii
Copy link
Copy Markdown
Member

ctubbsii commented Apr 30, 2019

I didn't try a build to see the warning. But yeah, it's warning of the same thing I was talking about.

The assembly descriptor references a set of components to include in the tarball. That list contains dependencies of the assemble module. The above warning indicates that the commons-collections:commons-collections artifact can't be found among the assemble module's dependencies and wasn't included. The reason is because it was replaced with the new groupId/artifactId... we just need to update the component.xml file to have the correct new groupId/artifactId for commons-collections.

ctubbsii added a commit to ctubbsii/accumulo that referenced this pull request May 9, 2019
@ctubbsii
Add missing LRUMap generic parameters
8e2c8e9 
Since the update to commons-collections 4.3 in apache#1110, the LRUMap now
accepts generic parameter types. This change adds those that were
missing, which gives us better type safety when using these maps.
@ctubbsii ctubbsii mentioned this pull request May 9, 2019
Merged
ctubbsii added a commit that referenced this pull request May 9, 2019
@ctubbsii
Add missing LRUMap generic parameters (#1156)
5e072bb 
Since the update to commons-collections 4.3 in #1110, the LRUMap now
accepts generic parameter types. This change adds those that were
missing, which gives us better type safety when using these maps.
@ctubbsii ctubbsii added this to the 2.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctubbsii ctubbsii ctubbsii left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@milleruntime @ctubbsii