Multiple code improvements - squid:SwitchLastCaseIsDefaultCheck, squid:S1197, squid:S1192, squid:S2131#117
Closed
georgekankava wants to merge 1 commit intoapache:masterfrom
DevFactory:release/multiple-code-improvements-fix-3
Closed
Multiple code improvements - squid:SwitchLastCaseIsDefaultCheck, squid:S1197, squid:S1192, squid:S2131#117georgekankava wants to merge 1 commit intoapache:masterfrom DevFactory:release/multiple-code-improvements-fix-3
georgekankava wants to merge 1 commit intoapache:masterfrom
DevFactory:release/multiple-code-improvements-fix-3
Conversation
…d:S1197, squid:S1192, squid:S2131
Member
|
|
Author
|
Same comment here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause.
squid:S1197 - Array designators "[]" should be on the type, not the variable.
squid:S1192 - String literals should not be duplicated.
squid:S2131 - Primitives should not be boxed just for "String" conversion.
This pull request removes technical debit of 80 minutes.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck
https://dev.eclipse.org/sonar/rules/show/squid:S1197
https://dev.eclipse.org/sonar/rules/show/squid:S1192
https://dev.eclipse.org/sonar/rules/show/squid:S2131
Please let me know if you have any questions.
George Kankava