Multiple code improvements - squid:1213, squid:S2275, squid:SwitchLastCaseIsDefaultCheck, squid:UselessImportCheck, squid:ClassVariableVisibilityCheck#118
Closed
georgekankava wants to merge 1 commit intoapache:masterfrom
DevFactory:release/multiple-code-improvements-fix-4
Closed
Multiple code improvements - squid:1213, squid:S2275, squid:SwitchLastCaseIsDefaultCheck, squid:UselessImportCheck, squid:ClassVariableVisibilityCheck#118georgekankava wants to merge 1 commit intoapache:masterfrom DevFactory:release/multiple-code-improvements-fix-4
georgekankava wants to merge 1 commit intoapache:masterfrom
DevFactory:release/multiple-code-improvements-fix-4
Conversation
…tCaseIsDefaultCheck, squid:UselessImportCheck, squid:ClassVariableVisibilityCheck
|
|
||
| public class ClientOpts extends Help { | ||
|
|
||
| public static class TimeConverter implements IStringConverter<Long> { |
Member
There was a problem hiding this comment.
I don't see the point behind you reorganizing this file.
Member
|
Again Please consolidate all of these pull requests into one. We do not need five pull requests for 2 to 3 nit-picky fixes. |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order.
squid:S2275 - Printf-style format strings should not lead to unexpected behavior at runtime.
squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause.
squid:UselessImportCheck - Useless imports should be removed.
squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.
This pull request removes technical debt of 168 minutes.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1213
https://dev.eclipse.org/sonar/rules/show/squid:S2275
https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck
https://dev.eclipse.org/sonar/rules/show/squid:UselessImportCheck
https://dev.eclipse.org/sonar/rules/show/squid:ClassVariableVisibilityCheck
Please let me know if you have any questions.
George Kankava