Replace use of deprecated newInstance calls.#1191
Closed
jmark99 wants to merge 2 commits intoapache:masterfrom
Closed
Replace use of deprecated newInstance calls.#1191jmark99 wants to merge 2 commits intoapache:masterfrom
jmark99 wants to merge 2 commits intoapache:masterfrom
Conversation
Calls to newInstance() are deprecated in JDK 9+. Replace with calls to getDeclaredConstructor().newInstance()
ctubbsii
approved these changes
Jun 10, 2019
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
This is good, but I think things can be cleaned up by using ReflectiveOperationException
core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java
Outdated
Show resolved
Hide resolved
Updated to use ReflectiveOperationException where applicable.
Contributor
Author
|
Merge changes. Closes #1191 |
ctubbsii
added a commit
to ctubbsii/accumulo
that referenced
this pull request
Jun 11, 2019
* Fixes apache#1192 (use Charset instead of String, where appropriate) * Fixes apache#1193 (replace Guava immutables with Java 11 built-ins) * Rebased onto apache#1191 (avoid deprecated Class.newInstance; conflicts resolved) * Configure Maven to build with Java 11 * Remove animal-sniffer (unnecessary with new javac release flag) * Add exceptions to spotbugs to avoid false positive bug (spotbugs/spotbugs#756)
ctubbsii
added a commit
to ctubbsii/accumulo
that referenced
this pull request
Jun 11, 2019
* Fixes apache#1192 (use Charset instead of String, where appropriate) * Fixes apache#1193 (replace Guava immutables with Java 11 built-ins) * Rebased onto apache#1191 (avoid deprecated Class.newInstance; conflicts resolved) * Configure Maven to build with Java 11 * Remove animal-sniffer (unnecessary with new javac release flag) * Add exceptions to spotbugs to avoid false positive bug (spotbugs/spotbugs#756)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to newInstance() are deprecated in JDK 9+. Replace with calls to
getDeclaredConstructor().newInstance()