ACCUMULO-4361 Configure ShellServerIT to run with one tserver#123
ACCUMULO-4361 Configure ShellServerIT to run with one tserver#123asfgit merged 1 commit intoapache:1.7from
Conversation
Refactored SharedMiniClusterIT a little bit to work around the static initialization of the MAC which previously would not have allowed tests to control how MAC is configured. This has the downside of forcing new tests to remember to define BeforeClass and AfterClass annotated methods which call the corresponding methods on SharedMiniClusterIT.
|
Ran all unit tests and the following ITs (a list I found that would be affected by the change to SharedMiniClusterIT): ArbitraryTablePropertiesIT,CreateTableWithNewTableConfigIT,ShellServerIT,SplitCancelsMajCIT,CleanUpIT,DeletedTablesDontFlushIT,TabletStateChangeIteratorIT,T*ProxyIT,StatusCombinerMacIT |
Did you run findbugs, checkstyle, etc? |
|
The changes look good. I can't think of a simpler way than making each subclass implement the before and after methods. Looked into the behavior of |
Yup
Thanks for giving it a look! I'll work on merging this through. |
|
Thanks for this @joshelser |
Refactored SharedMiniClusterIT a little bit to work around the
static initialization of the MAC which previously would not have
allowed tests to control how MAC is configured. This has the downside
of forcing new tests to remember to define BeforeClass and AfterClass
annotated methods which call the corresponding methods on SharedMiniClusterIT.