Skip to content

ACCUMULO-4361 Configure ShellServerIT to run with one tserver#123

Merged
asfgit merged 1 commit intoapache:1.7from
joshelser:ACCUMULO-4361
Jul 11, 2016
Merged

ACCUMULO-4361 Configure ShellServerIT to run with one tserver#123
asfgit merged 1 commit intoapache:1.7from
joshelser:ACCUMULO-4361

Conversation

@joshelser
Copy link
Copy Markdown
Member

Refactored SharedMiniClusterIT a little bit to work around the
static initialization of the MAC which previously would not have
allowed tests to control how MAC is configured. This has the downside
of forcing new tests to remember to define BeforeClass and AfterClass
annotated methods which call the corresponding methods on SharedMiniClusterIT.

Refactored SharedMiniClusterIT a little bit to work around the
static initialization of the MAC which previously would not have
allowed tests to control how MAC is configured. This has the downside
of forcing new tests to remember to define BeforeClass and AfterClass
annotated methods which call the corresponding methods on SharedMiniClusterIT.
@joshelser
Copy link
Copy Markdown
Member Author

Ran all unit tests and the following ITs (a list I found that would be affected by the change to SharedMiniClusterIT): ArbitraryTablePropertiesIT,CreateTableWithNewTableConfigIT,ShellServerIT,SplitCancelsMajCIT,CleanUpIT,DeletedTablesDontFlushIT,TabletStateChangeIteratorIT,T*ProxyIT,StatusCombinerMacIT

@keith-turner
Copy link
Copy Markdown
Contributor

Ran all unit tests and the following ITs

Did you run findbugs, checkstyle, etc?

@keith-turner
Copy link
Copy Markdown
Contributor

The changes look good. I can't think of a simpler way than making each subclass implement the before and after methods. Looked into the behavior of @BeforeClass and junit seems to always call the @BeforeClass method in the superclass 1st.

@joshelser
Copy link
Copy Markdown
Member Author

Did you run findbugs, checkstyle, etc?

Yup

The changes look good. I can't think of a simpler way than making each subclass implement the before and after methods

Thanks for giving it a look! I'll work on merging this through.

@asfgit asfgit merged commit 1d5cd11 into apache:1.7 Jul 11, 2016
@mjwall
Copy link
Copy Markdown
Member

mjwall commented Jul 11, 2016

Thanks for this @joshelser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants