Merged
Conversation
ctubbsii
approved these changes
Jul 21, 2019
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
👍 Could change this PR base to 2.0.
Contributor
Author
|
Ignore the next set of changes. Ran into some small issues changing the base to 2.0. Hopefully everything is in order now. |
hkeebler
reviewed
Jul 22, 2019
Contributor
hkeebler
left a comment
hkeebler
left a comment
There was a problem hiding this comment.
Curious, why not use
If (size > 0)
updateMetrics.addCommitTime((long) (time / (double) size));
Member
I agree, this would be more succinct. |
ctubbsii
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the requested changes from Christopher in issue #1222.
Tested using continuous ingest with agitation and did not run into the bug. Please let me know if I should do further testing or make any corrections